Skip to content

feat(indicator): add secondary values and number formatting - #972

Draft
kuzmadom wants to merge 1 commit into
release/v8from
feat/indicator-extensions-v8
Draft

kuzmadom wants to merge 1 commit into
release/v8from
feat/indicator-extensions-v8

Conversation

@kuzmadom

Copy link
Copy Markdown
Contributor

Adds secondary indicator values with captions, arrows, colors, and placement to the right or below the main value. Both values support independent number formatting. Preserves compatibility with the legacy configuration.

(cherry picked from commit 860e627)

Adapt the backport to release/v8: retain lodash and the default renderer export,
update the icons lock entry, and use UIKit 7 label metrics in visual assertions.
Check the published indicator types with v8 bundler and node resolution in CI.
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.63% 400 / 1624
🔵 Statements 24.8% 415 / 1673
🔵 Functions 19.49% 69 / 354
🔵 Branches 18.84% 239 / 1268
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ErrorBoundary/ErrorBoundary.tsx 0% 0% 0% 0% 19-68
src/plugins/indicator/index.ts 0% 100% 0% 0% 7-9
src/plugins/indicator/normalize.ts 91.66% 88.57% 100% 91.3% 17, 37
src/plugins/indicator/public-types.ts 100% 100% 100% 100%
src/plugins/indicator/types.ts 100% 100% 100% 100%
src/plugins/indicator/renderer/IndicatorItem.tsx 0% 0% 0% 0% 8-36
src/plugins/indicator/renderer/IndicatorSecondaryValue.tsx 0% 0% 0% 0% 9-61
src/plugins/indicator/renderer/IndicatorWidget.tsx 0% 0% 0% 0% 19-80
src/plugins/indicator/renderer/utils.ts 100% 100% 100% 100%
src/plugins/shared/format-number/format-number.ts 97.95% 100% 85.71% 97.95% 110
src/plugins/shared/format-number/types.ts 100% 100% 100% 100%
src/types/index.ts 100% 100% 100% 100%
src/types/widget.ts 100% 100% 100% 100%
Generated in workflow #411 for commit 732ece0 by the Vitest Coverage Report Action

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

🎭 Tests Report is ready.
🎭 Coverage Report is ready.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants