Repository navigation
fix(provisions): propagate network subgraph query failures - #1260
Merged
tmigone merged 2 commits intoOct 20, 2026
Merged
Conversation
tmigone
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Network Subgraph provisions query returns a GraphQL error, the resolver logs it and then reads
result.data.provisions. Missing data replaces the useful upstream error with a TypeError; partial data can return incomplete provision evidence. Propagate the original query error before consuming its data.The existing test configuration also treated an empty RPC environment variable as a configured endpoint, bypassing its public Arbitrum Sepolia fallback. Fork CI supplies unavailable secrets as empty strings, causing seven existing suites to fail during configuration parsing. Treat an empty override like an unset override while preserving explicit endpoints.
Validation: the missing/partial provisions regressions and empty-RPC configuration case fail before their fixes and pass afterward. Six focused tests across the resolver and test-configuration files pass, with scoped ESLint and Prettier. These focused tests require no database or RPC service. Full repository tests, including existing live integration coverage, remain in CI; no assertions or credential boundaries were weakened.