Repository navigation
feat(server): emit typed response headers without model name collisions - #116
Merged
Merged
Conversation
Response Objects with declared headers now produce a
{Enum}{Variant}Headers struct as the variant's last field and
into_response appends each value as its own header line.
Set-Cookie is always multi-value per RFC 9110 section 5.3;
a declared Content-Type stays ignored per the specification.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #114 and includes the original commits from #115, plus a fix for generated header structs shadowing response body models.
Generated Axum response variants now carry declared headers, including separate Set-Cookie lines. Header struct names reserve existing model, parameter-enum, and response-enum names and receive numeric suffixes on collision. String cookie parameters in generated clients use AsRef correctly.
Regression coverage includes two occupied model names, parameter-enum collisions, stable public names across selector order, and HTTP round trips checking JSON bodies and multiple Set-Cookie headers. Responses without declared headers retain their shape.
Validation:
Merge with a merge commit to preserve #115's ancestry.