Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the connection generator to conditionally include the "google/cloud/internal/make_stream_range.h" header in generated connection source files when a streaming read method is present. Consequently, various generated connection source files have been updated to include this header. There are no review comments, and I have no feedback to provide.
scotthart
marked this pull request as draft
October 14, 2026 19:37
scotthart
force-pushed
the
generator_streaming_pagination_includes
branch
from
October 14, 2026 20:24
c43182e to
88e9234
Compare
scotthart
marked this pull request as ready for review
October 14, 2026 20:24
colinmoy
approved these changes
Oct 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16565 +/- ##
==========================================
- Coverage 92.39% 92.37% -0.03%
==========================================
Files 2265 2266 +1
Lines 219470 219471 +1
==========================================
- Hits 202786 202733 -53
- Misses 16684 16738 +54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for some refactoring of stream_range.h and removes relying on transitive includes.
Added a new file google/cloud/internal/make_stream_range.h, relocated the factory functions from stream_range.h to it, and updated call sites in all code.