Repository navigation
Conversation
Author
|
This is prob not necessary as I revisit, closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MOSS requires that our builds use Airlock. The goal is to pull all third-party dependencies only from Airlock, which is the trusted source. This PR fixes the same blocker that b/573257533 reports for google-oauth-java-client.
Problem
pom.xmlmanagesjavax.jdo:jdo2-api:2.3-20090302111651independencyManagement. No module declaresjdo2-apitoday. But dependency scans can still see the managed version, and any module that addsjdo2-apigets this version.<licenses>block.20090302111651sorts aftereb. But the20090302111651jar is older. Its manifest dates it to 2008-12-28 and saysImplementation-Version: 2.3-SNAPSHOT. The2.3-ebjar dates from January 2010.Fix
This PR replaces the dependency with
javax.jdo:jdo2-api:2.3-eb. Airlock validates this version (it is inmaven-3p-trusted), and its POM declares Apache 2.0.pom.xml: setproject.jdo2-api.versionto2.3-eb.renovate.json: disable Renovate updates forjavax.jdo:jdo2-api, so that Renovate does not open chore(deps): update dependency javax.jdo:jdo2-api to v2.3-20090302111651 #1952 again.Testing and verification
Why I think this change is safe:
jdo2-api, so the change does not affect any published module.javax.jdo) and the artifactId do not change.2.3-eb, and the enhanced bytecode is byte-identical.Tests I did:
mvn validatepasses.jdo2-apiat2.3-eb.