Skip to content

Harden update-dependency-reminder workflow - #3251

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:harden-lockfile-workflow
Oct 26, 2026
Merged

gbrodman merged 1 commit into
google:masterfrom
gbrodman:harden-lockfile-workflow

Conversation

@gbrodman

@gbrodman gbrodman commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Harden .github/workflows/update-dependency-reminder.yml for GitHub's upcoming pull_request_target event policy enforcement (b/577107502):

  • Declare top-level permissions: {} to enforce minimal default workflow permissions.
  • Add # zizmor: ignore[dangerous-triggers] annotation documenting why pull_request_target is safe (no PR code is checked out).
  • Pin actions/github-script to its full v7.1.0 commit SHA (f28e40c7f34bde8b3046d885e986cb6290c5673b).

This change is Reviewable

Harden .github/workflows/update-dependency-reminder.yml for GitHub's
upcoming pull_request_target event policy enforcement (b/577107502):

- Declare top-level `permissions: {}` to enforce minimal default
  workflow permissions.
- Add `# zizmor: ignore[dangerous-triggers]` annotation documenting why
  `pull_request_target` is safe (no PR code is checked out).
- Pin `actions/github-script` to its full v7.1.0 commit SHA
  (`f28e40c7f34bde8b3046d885e986cb6290c5673b`).
@gbrodman
gbrodman requested a review from weiminyu October 23, 2026 20:19

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@gbrodman
gbrodman added this pull request to the merge queue Oct 26, 2026
Merged via the queue into google:master with commit bfd99a8 Oct 26, 2026
16 checks passed
@gbrodman
gbrodman deleted the harden-lockfile-workflow branch October 26, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants