Repository navigation
Indent text blocks in the main formatting pass - #1486
Merged
Merged
Conversation
This fixes a pre-existing issue in text block formatting if `--skip-reflowing-long-strings` is disabled, which can be triggered by the recent changes to lambda formatting. Fixes #19 (comment) Previously, text block normalization and re-indentation ran only in `StringWrapper`, so callers that pass `--skip-reflowing-long-strings` moved the opening `"""` delimiter without updating the indentation of the text block body. Move text block line normalization into `JavaInputAstVisitor` and emit multi-line tokens via `LayoutBuilder.multilineToken` and `Doc.Lines`, which `LayoutSolver` indents to the current line's indentation. PiperOrigin-RevId: 1002276705
copybara-service
Bot
force-pushed
the
test_1001065554
branch
from
October 19, 2026 12:49
039d24d to
d8312fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indent text blocks in the main formatting pass
This fixes a pre-existing issue in text block formatting if
--skip-reflowing-long-stringsis disabled, which can be triggered by the recent changes to lambda formatting.Fixes #19 (comment)
Previously, text block normalization and re-indentation ran only in
StringWrapper, so callers that pass--skip-reflowing-long-stringsmoved the opening"""delimiter without updating the indentation of the text block body.Move text block line normalization into
JavaInputAstVisitorand emit multi-line tokens viaLayoutBuilder.multilineTokenandDoc.Lines, whichLayoutSolverindents to the current line's indentation.