Repository navigation
Exempt Apache Beam DoFn method annotations in WellKnownKeep - #6212
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1000965637
branch
from
October 20, 2026 19:52
cb09ce5 to
6562dc1
Compare
Add all Beam DoFn callback and lifecycle annotations to WellKnownKeep's EXEMPTING_METHOD_ANNOTATIONS list: - Timer callbacks: @ontimer, @OnTimerFamily - Lifecycle methods: @setup, @teardown, @OnWindowExpiration - Execution constraints: @RequiresStableInput, @RequiresTimeSortedInput - Splittable DoFn methods: @GetInitialRestriction, @SplitRestriction, @TruncateRestriction, @GetRestrictionCoder, @NewTracker, @Getsize, @GetInitialWatermarkEstimatorState, @GetWatermarkEstimatorStateCoder, @NewWatermarkEstimator Previously only ProcessElement, StartBundle, and FinishBundle were recognized, leading to false positives in UnusedMethod and EffectivelyPrivate on methods invoked reflectively or dynamically by the Beam runner. PiperOrigin-RevId: 1003345994
copybara-service
Bot
force-pushed
the
test_1000965637
branch
from
October 20, 2026 20:23
6562dc1 to
47eb5be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exempt Apache Beam DoFn method annotations in WellKnownKeep
Add all Beam DoFn callback and lifecycle annotations to WellKnownKeep's EXEMPTING_METHOD_ANNOTATIONS list:
Previously only ProcessElement, StartBundle, and FinishBundle were recognized, leading to false positives in UnusedMethod and EffectivelyPrivate on methods invoked reflectively or dynamically by the Beam runner.