Skip to content

Show legacy PHOTO media as product images #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wcole1-godaddy merged 1 commit into from
Oct 14, 2026
+24 −2
Merged

Show legacy PHOTO media as product images #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/commerce-server/src/lib/commerce/catalog-subgraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,13 @@ export function getAvailableInventoryQuantity(
return edges.find((edge) => edge?.node?.type === 'AVAILABLE')?.node?.quantity ?? 0;
}

// The catalog API still returns `PHOTO` for media created before the `IMAGE` type.
const imageMediaTypes: ReadonlySet<string> = new Set(['IMAGE', 'PHOTO']);

export function getImageUrls(item: MediaObjectContainer | null | undefined): string[] {
return (
item?.mediaObjects?.edges
?.filter((edge) => edge?.node?.type === 'IMAGE' && edge.node.url)
?.filter((edge) => imageMediaTypes.has(edge?.node?.type ?? '') && edge?.node?.url)
.map((edge) => edge?.node?.url)
.filter((url): url is string => Boolean(url)) ?? []
);
Expand Down
16 changes: 16 additions & 0 deletions packages/commerce-storefront/src/catalog-model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { describe, expect, it } from 'vitest';
import {
getAvailableInventoryQuantity,
getImageUrls,
getLabeledSkuOptions,
getSingleMatchedSku,
type SKU,
Expand Down Expand Up @@ -47,4 +48,19 @@ describe('safe SKU selection', () => {
}),
).toBe(2);
});
it('treats legacy PHOTO media as images and skips other media', () => {
expect(
getImageUrls({
mediaObjects: {
edges: [
{ node: { type: 'PHOTO', url: '/legacy.jpg' } },
{ node: { type: 'VIDEO', url: '/clip.mp4' } },
{ node: { type: 'IMAGE', url: '/current.jpg' } },
{ node: { type: 'IMAGE', url: '' } },
null,
],
},
}),
).toEqual(['/legacy.jpg', '/current.jpg']);
});
});
5 changes: 4 additions & 1 deletion packages/commerce-storefront/src/catalog-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,13 @@ export function getAvailableInventoryQuantity(
return edges.find((edge) => edge?.node?.type === 'AVAILABLE')?.node?.quantity ?? 0;
}

// The catalog API still returns `PHOTO` for media created before the `IMAGE` type.
const imageMediaTypes: ReadonlySet<string> = new Set(['IMAGE', 'PHOTO']);

export function getImageUrls(item: MediaObjectContainer | null | undefined): string[] {
return (
item?.mediaObjects?.edges
?.filter((edge) => edge?.node?.type === 'IMAGE' && edge.node.url)
?.filter((edge) => imageMediaTypes.has(edge?.node?.type ?? '') && edge?.node?.url)
.map((edge) => edge?.node?.url)
.filter((url): url is string => Boolean(url)) ?? []
);
Expand Down
Loading