Repository navigation
accept a zero ThresholdFactor in isoutlier - #536
Merged
Merged
Conversation
pr0m1th3as
added a commit
that referenced
this pull request
Oct 31, 2026
Follow-up to #536. An integer or single factor now gives double thresholds, as in MATLAB, where an integer one gave rounded values. * inst/Data_Manipulation/isoutlier.m: check the type of 'ThresholdFactor' and cast it to double; state the zero and tiny factor results for 'grubbs' and 'gesd'; add tests. * inst/Data_Manipulation/doc-cache: refresh isoutlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThresholdFactoris documented as anonnegative scalar, but the input check used<= 0, so a value of 0 was rejected.BEFORE:
AFTER:
MATLAB: