Repository navigation
Conversation
Normal attribute lookup makes string indexing return list methods for item names such as `count`, and reports absent `append` identifiers as present. Use `__getattr__` explicitly for identifier lookup and remove its fallback to list attributes. Ordinary attribute access still exposes list methods. Add twelve present/absent collision cases with and without prefixes. The full suite passes 1701 tests, 89 conditional skips, one existing xfail, and 64 subtests; pinned hooks, type checks, docs and packaging also pass.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 18:19
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
What changed in this PR
Updates IterableList name-based lookup so string indexing and membership checks resolve items by identifier rather than colliding with built-in list attributes/methods (e.g., append, sort), and adds regression tests for these edge cases.
Changes:
- Route
__contains__and string__getitem__throughIterableList.__getattr__instead of Python attribute lookup. - Change
__getattr__fallback from list attribute access to raisingAttributeErrorwhen no matching item exists. - Add parametrized regression tests covering list-method names, dunder/internal names, prefixes, and deletion.
| File | Description |
|---|---|
git/util.py |
Adjusts IterableList lookup semantics to avoid list attribute collisions and to raise on missing identifiers. |
test/test_util.py |
Adds regression tests ensuring identifier lookup works even for names that match list methods/dunders and after deletion. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return getattr(self, cast(str, index)) | ||
| return self.__getattr__(cast(str, index)) | ||
| except AttributeError as e: | ||
| raise IndexError(f"No item found with id {self._prefix}{index}") from e |
| return item | ||
| # END for each item | ||
| return list.__getattribute__(self, attr) | ||
| raise AttributeError(f"No item found with id {attr}") |
Copilot stopped reviewing on behalf of
Byron due to an error
October 12, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was prepared by an OpenAI Codex agent.
IterableListstring indexing currently uses normal attribute lookup. Consequently, names such ascount,sort, orappendreturn list methods rather than matching items, and an absentappendis reported as present. This also affects named references and submodules, as described in #1091 (currently closed as not planned).Route string indexing and identifier membership through the existing identifier lookup, and raise
AttributeErrorwhen no matching item exists instead of falling back to list attributes. Ordinary attribute access to list methods remains available.Twelve regression cases cover list-method names, internal/dunder names, ordinary names, and prefixed identifiers, including absence after deletion. Ten fail against pristine source; the two ordinary-name controls pass.
Validation on CPython 3.12.14 / Linux / Git 2.52.0:
git diff --checkpassed.The unchanged skips are platform/filesystem-specific, and the existing xfail concerns shallow submodules. One unchanged path-environment deprecation warning remains. Other operating systems and Python versions were not run locally; hosted results are reported separately.