Repository navigation
fix(cli): Show oversized drops that finish after a session closes - #2400
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
A request that was still being read when a session closed could end in a 413 after the stream had already sent its closing frame, so the tail never warned about the dropped envelope. The session now drains requests it started reading, so the oversized notice comes first. Decoding still runs after close to apply the 32 MiB limit, and nothing is retained. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3dff459. Configure here.
The closed check ran after decoding, so a body that had fully arrived before close but was still queued or decoding got 410 and was dropped. Check whether the session is closed when the body finishes arriving instead, and still apply the size limits first.
…lose # Conflicts: # packages/cli/src/commands/local/receiver-ingest.ts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #2347.
If a session closed while an ingest request was still being read, the request could still end in a 413, but by then the stream had already sent
retainedand ended. So the tail never printed the oversized-envelope warning.Now the session waits for requests it already started reading before it sends the closing frame. A late request is still never saved: it gets 413 if it's too big, and 410 otherwise. Requests that arrive after the close still get 410 right away. The size limits stay the same: 10 MiB encoded, 32 MiB decoded.
Before
After
One tradeoff: a client that stalls in the middle of a body now holds back the closing frame until its body finishes or the connection drops.
via @MathurAditya724.
--
View Session [Sentry]