Repository navigation
fix(cli): Warn that hard-coded SDKs miss the free-port fallback - #2398
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
When the Local daemon holds port 8969, a plain `local run` captures on a free port. The daemon drops traffic that isn't for a session, so an SDK that hard-codes 8969 lost everything with no hint. The notice now names the port in use and says to read SENTRY_SPOTLIGHT, the same way the --verify fallback does. Both notices come from one helper so their wording can't drift. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…otice # Conflicts: # packages/cli/test/commands/local/run.test.ts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2370. When the Local daemon holds port 8969, a plain
local runcaptures on a free port. The daemon quietly drops anything that isn't session traffic, so an SDK that hard-codes 8969 (common in browser setups) lost every event with no hint why.The notice now gives the port it picked and says to read
SENTRY_SPOTLIGHT.--verifyalready had a warning like this, so both now come from one small helper and can't drift apart.Before:
After:
via @MathurAditya724.
--
View Session [Sentry]