Repository navigation
fix(cli): Keep SDK log attributes log-only in sentry local - #2394
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
The keys added to hide SDK log noise also moved transaction and span attributes such as user.email and asctime into the sdk group. They now apply to logs only. - Only the scope user keys (user.id, user.email, user.name, user.username, user.ip_address) are hidden, so custom user.* keys show. - A bare request is hidden only for Python or an object repr. - sentry-rust's os.name, os.version and parent_span_id, and sentry-ruby's parameters, are hidden on those SDKs' logs. - event list ranks warn and warning logs the same. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…te-scope # Conflicts: # packages/cli/src/lib/formatters/local.ts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2369 and #2377.
The keys we started hiding on log lines (
user.*,asctime,request,server_time,logger.*) were also applied to transactions and spans. So-amoved a span'suser.emailinto thesdkgroup. They now only apply to logs.Other small fixes:
user.id,user.email,user.name,user.username,user.ip_address). Your ownuser.planstill shows.requestis hidden only on Python logs, or when it's an object repr like<WSGIRequest …>.os.name,os.versionandparent_span_id. Ruby logs hideparameters. Other SDKs keep those as normal attributes.event listrankswarnandwarninglogs the same.-ahelp now says "transaction, span and log".Before:
After:
via @MathurAditya724.
--
View Session [Sentry]