Skip to content

fix(local): Keep receive times out of trace timing - #2392

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
fix/local-receive-time-followup
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
fix/local-receive-time-followup

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2373, from its review.

To show a time on items that don't have one, like replay recordings and cron check-ins, we wrote the receive time into the item's timestamp. Trace timing reads that same field. So a check-in that arrived a few minutes after its transaction made the whole trace look minutes long. Now the receive time goes in its own field, and it's only used to show and sort items.

While here:

  • Span start and end times show milliseconds, plus the date when it isn't today. Before, a 40 ms span showed the same start and end.
  • ANSI colour codes are stripped from nested values in attribute tables too, not just top-level strings.
  • A pasted session link is always cleared from the address bar, even when the viewer refuses its stream. This only applies when the link is pasted on the same page, since a different path is a normal page load.

Before / after:

Trace with a 400 ms transaction + a check-in received 222 s later
  before: nightly-report · 222.40 s
  after:  nightly-report · 400.00 ms

Span detail, 40 ms span
  before: Start 10:13:20 PM   End 10:13:20 PM
  after:  Start 11/14/2023 10:13:20.538 PM   End 11/14/2023 10:13:20.578 PM

via @MathurAditya724.

--

View Session [Sentry]

Items with no SDK time showed their receive time by writing it into
`timestamp`, which trace timing also reads. A check-in that arrived
minutes after its transaction stretched the trace to match. Keep the
receive time in its own field, used only to show and sort items.

Also from review of the earlier viewer fixes:
- Span start and end times show milliseconds, and the date when it is
  not today.
- Attribute values strip ANSI codes from nested strings too.
- A pasted link is cleared from the address bar even when its stream is
  refused; fragment parsing is shared in readConnectionLink.

Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cli Ready Ready Preview Nov 18, 2026 10:11pm UTC
sentry-local Ready Ready Preview Nov 18, 2026 10:11pm UTC

Request Review

@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 18, 2026 19:41
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 18, 2026
…e-followup

# Conflicts:
#	apps/local/src/components/inspector-data.ts
#	apps/local/src/lib/inspection.ts
#	apps/local/src/lib/spotlight.ts

This branch was successfully deployed

3 active (1 outdated) deployments
Preview – sentry-local — 720460e7 Deployed Nov 18, 2026 by vercel[bot]
Preview – cli — 720460e7 Deployed Nov 18, 2026 by vercel[bot]
Preview — 9d711edf Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant