Repository navigation
fix(local): Keep receive times out of trace timing - #2392
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Items with no SDK time showed their receive time by writing it into `timestamp`, which trace timing also reads. A check-in that arrived minutes after its transaction stretched the trace to match. Keep the receive time in its own field, used only to show and sort items. Also from review of the earlier viewer fixes: - Span start and end times show milliseconds, and the date when it is not today. - Attribute values strip ANSI codes from nested strings too. - A pasted link is cleared from the address bar even when its stream is refused; fragment parsing is shared in readConnectionLink. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e-followup # Conflicts: # apps/local/src/components/inspector-data.ts # apps/local/src/lib/inspection.ts # apps/local/src/lib/spotlight.ts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2373, from its review.
To show a time on items that don't have one, like replay recordings and cron check-ins, we wrote the receive time into the item's
timestamp. Trace timing reads that same field. So a check-in that arrived a few minutes after its transaction made the whole trace look minutes long. Now the receive time goes in its own field, and it's only used to show and sort items.While here:
Before / after:
via @MathurAditya724.
--
View Session [Sentry]