Repository navigation
fix(local): Share the HTTP target order and tidy trace review follow-ups - #2391
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
- Read HTTP targets in one shared order (http.route, url.template, url.full, url.path) in both the viewer and the CLI tail. - Keep the host on method-only client spans and match methods in any case. - Use pluralize for the remaining hand-written plurals. - Name each sampled-functions toggle after its span, unfold only the sampled rows that match a search, and re-show a selected sampled row when the selection changes. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f1b454. Configure here.
Keep case-insensitive method matching in withCapturedUrl with main's strict-policy match handling, and add the explicit return TypeScript 7 now requires in httpTargetAttribute.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes the review findings left over from #2371 and #2372.
HTTP span labels. The viewer and the CLI tail now pick an HTTP span's target in the same order:
http.route,url.template,url.full, thenurl.path. That order lives in one small helper,packages/cli/src/commands/local/http-target.ts. Spans named only by a method also work when the method is lowercase. Client spans keep the host they called.http.servernamedGET,url.template: /api/items/{id}GET /api/items/7GET /api/items/{id}http.clientnamedGETcalling StripeGET /v1/chargesGET api.stripe.com/v1/chargeshttp.servernamedgetgetget /api/edgeSampled functions in the waterfall:
Plurals. The last hand-written plurals in the event list, filters, Web Vitals and waterfall now use
pluralize.via @MathurAditya724.
--
View Session [Sentry]