Skip to content

fix(local): Share the HTTP target order and tidy trace review follow-ups - #2391

Open
sentry-junior[bot] wants to merge 3 commits into
mainfrom
fix/local-trace-review-followups
Open

sentry-junior[bot] wants to merge 3 commits into
mainfrom
fix/local-trace-review-followups

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

This fixes the review findings left over from #2371 and #2372.

HTTP span labels. The viewer and the CLI tail now pick an HTTP span's target in the same order: http.route, url.template, url.full, then url.path. That order lives in one small helper, packages/cli/src/commands/local/http-target.ts. Spans named only by a method also work when the method is lowercase. Client spans keep the host they called.

Span Before After
http.server named GET, url.template: /api/items/{id} GET /api/items/7 GET /api/items/{id}
http.client named GET calling Stripe GET /v1/charges GET api.stripe.com/v1/charges
http.server named get get get /api/edge

Sampled functions in the waterfall:

  • Each "Show/Hide sampled functions" button now has its own accessible name, such as "Show 3 sampled functions under GET /slow". Before, every one of them was called "Show 3 sampled functions".
  • Search only unfolds sampled rows that match. Before, searching "SELECT" opened every sampled row in the trace.
  • Picking a sampled row after the waterfall is already open now unfolds its siblings. Before, they only opened on first load.

Plurals. The last hand-written plurals in the event list, filters, Web Vitals and waterfall now use pluralize.

via @MathurAditya724.

--

View Session [Sentry]

- Read HTTP targets in one shared order (http.route, url.template,
  url.full, url.path) in both the viewer and the CLI tail.
- Keep the host on method-only client spans and match methods in any
  case.
- Use pluralize for the remaining hand-written plurals.
- Name each sampled-functions toggle after its span, unfold only the
  sampled rows that match a search, and re-show a selected sampled row
  when the selection changes.

Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cli Ready Ready Preview Nov 18, 2026 10:12pm UTC
sentry-local Ready Ready Preview Nov 18, 2026 10:12pm UTC

Request Review

@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 18, 2026 19:44
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 18, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2f1b454. Configure here.

Comment thread apps/local/src/lib/trace-model.ts Resolved
Keep case-insensitive method matching in withCapturedUrl with main's
strict-policy match handling, and add the explicit return TypeScript 7
now requires in httpTargetAttribute.

This branch was successfully deployed

3 active (1 outdated) deployments
Preview – sentry-local — b3425d32 Deployed Nov 18, 2026 by vercel[bot]
Preview – cli — b3425d32 Deployed Nov 18, 2026 by vercel[bot]
Preview — b90030b0 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant