Repository navigation
ref(lint): Enable no-unnecessary-condition in cli #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
97ae18b
278cda9
157b4c9
372f73d
f0f513c
67f96a0
5f7cf1b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -339,7 +339,7 @@ | |
| ); | ||
| const filteredRows = flags.query | ||
| ? allRows.filter((row) => | ||
| (row.rule.name ?? "") | ||
| ((row.rule.name as string | null) ?? "") | ||
| .toLowerCase() | ||
| .includes(flags.query?.toLowerCase() ?? ""), | ||
| ) | ||
|
|
@@ -464,7 +464,7 @@ | |
|
|
||
| const tableRows: Row[] = rows.map(({ rule: r, orgSlug }) => ({ | ||
| id: r.id, | ||
| name: tableCell(r.name ?? "(untitled)"), | ||
| name: tableCell(r.name), | ||
|
Check warning on line 467 in packages/cli/src/commands/alert/metrics/list.ts
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Null metric alert name crashes human list output When the detectors API returns a null Evidence
Identified by Warden · code-review · SX4-WJ2 |
||
| ...(isMultiOrg && { org: orgSlug }), | ||
| aggregate: r.aggregate, | ||
| dataset: r.dataset, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.