Skip to content

feat(charts): Draw a marker on the plot for severe annotations - #131749

Open
adrianviquez wants to merge 3 commits into
masterfrom
adrian/explore-severe-annotation-markers
Open

adrianviquez wants to merge 3 commits into
masterfrom
adrian/explore-severe-annotation-markers

Conversation

@adrianviquez

@adrianviquez adrianviquez commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

This adds a marker on the chart for severe annotations: a dotted red line from the top of the plot down to the bands, with a circle on top, centered on its bucket. A bucket with one or more severe annotations gets a single marker.

Screenshot 2026-11-18 at 7 18 37 PM

Closes BROWSE-904

@adrianviquez
adrianviquez requested review from a team as code owners November 19, 2026 02:15
@linear-code

linear-code Bot commented Nov 19, 2026

Copy link
Copy Markdown

BROWSE-904

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-l8czihxm3.sentry.dev

@github-actions

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 96.08% 96.08% ±0%
Typed 144,051 144,072 🟢 +21
Untyped 5,878 5,879 🔴 +1
🔍 1 new type safety issue introduced

Type assertions (as) (1 new)

File Line Detail
static/app/components/charts/markers/useAnnotationMarkers.tsx 38 as CartesianCoordSys — params.coordSys as CartesianCoordSys

This is informational only and does not block the PR.

@adrianviquez

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 6d91f3c. Configure here.

This branch was successfully deployed

1 active deployment
Preview — 6d91f3cc Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant