Repository navigation
fix(aci): Convert string alert condition results to booleans - #131747
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Some alert conditions were saved with condition_result "true" or "false" strings, which fail evaluation so the alert never fires. This post-deploy migration converts them to booleans. Refs SENTRY-608Y Co-Authored-By: Kyle Consalus <6990351+kcons@users.noreply.github.com>
kcons
marked this pull request as ready for review
November 19, 2026 01:38
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some alert conditions were saved with the string
"true"or"false"as their condition result. These fail evaluation, so the alert never fires. This post-deploy migration converts them to booleans. Detector conditions are left alone because they use priority levels.#129225 stops the API from storing new string values. Merge this PR once that one is deployed.
Fixes SENTRY-608Y
via @kcons.
--
View Session [Sentry]