Skip to content

fix(aci): Convert string alert condition results to booleans - #131747

Open
sentry-junior[bot] wants to merge 1 commit into
masterfrom
kc/backfill-boolean-condition-results
Open

sentry-junior[bot] wants to merge 1 commit into
masterfrom
kc/backfill-boolean-condition-results

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Some alert conditions were saved with the string "true" or "false" as their condition result. These fail evaluation, so the alert never fires. This post-deploy migration converts them to booleans. Detector conditions are left alone because they use priority levels.

#129225 stops the API from storing new string values. Merge this PR once that one is deployed.

Fixes SENTRY-608Y

via @kcons.

--

View Session [Sentry]

Some alert conditions were saved with condition_result "true" or "false"
strings, which fail evaluation so the alert never fires. This post-deploy
migration converts them to booleans.

Refs SENTRY-608Y

Co-Authored-By: Kyle Consalus <6990351+kcons@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 19, 2026
@kcons
kcons marked this pull request as ready for review November 19, 2026 01:38
@kcons
kcons requested a review from a team as a code owner November 19, 2026 01:38
@sentry-junior
sentry-junior Bot requested a review from kcons November 19, 2026 01:38
@kcons
kcons requested review from a team and removed request for kcons November 19, 2026 01:38
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0127_normalize_string_condition_results.py

for 0127_normalize_string_condition_results in workflow_engine

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant