Repository navigation
feat(charts): Add tabs to the chart context drawer - #131744
Open
adrianviquez wants to merge 4 commits into
Open
adrianviquez wants to merge 4 commits into
adrianviquez wants to merge 4 commits into
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-gs5jpknwi.sentry.dev |
Contributor
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4d9a85d. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns the dropped data drawer on spans charts into a drawer with Dropped data, Releases, and Flags tabs. Clicking on each band gets you to one of the tabs. For now, the Releases and Flags tabs just say "Table coming soon".
The drawer moved to
charts/contextDrawer/asChartContextDrawer, and the selected tab is kept in a newcontextTabURL param. Other charts keep the drawer without tabs.Closes BROWSE-903