Skip to content

fix(crons): Refresh last successful time on orphaned incidents - #131743

Open
wedamija wants to merge 1 commit into
masterfrom
danf/crons-orphan-incident-last-successful
Open

wedamija wants to merge 1 commit into
masterfrom
danf/crons-orphan-incident-last-successful

Conversation

@wedamija

Copy link
Copy Markdown
Member

Part of storing the last successful check-in time on monitor incidents, so incident occurrences don't need a check-in lookup.

A race can leave an open incident on a monitor environment whose status is OK. The next failure reuses that incident through get_or_create, so its last successful time was stale. This sets it from the same lookup used for new incidents.

Part of storing the last successful check-in time on monitor incidents, so
incident occurrences don't need a check-in lookup.

A race can leave an open incident on a monitor environment whose status is
OK. The next failure reuses that incident through get_or_create, so its last
successful time was stale. This sets it from the same lookup used for new
incidents.
@wedamija
wedamija requested a review from a team as a code owner November 19, 2026 01:05
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant