Repository navigation
fix(jira): Halt status sync when the target status has no transition - #131738
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Outbound status sync logged jira.status-sync-fail and returned when no workflow transition reached the configured status, so the task recorded the lifecycle as a success and fired the synced analytics event. Raise IntegrationConfigurationError instead and halt on it in the task. Co-Authored-By: Richard Roggenkemper <richard.roggenkemper@sentry.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When outbound status sync can't find a Jira workflow transition to the configured status,
sync_status_outboundloggedjira.status-sync-failand returned. The task then recorded theOUTBOUND_STATUS_SYNClifecycle as a success and firedIntegrationIssueStatusSyncedEvent, so these failures were invisible in our metrics.This raises
IntegrationConfigurationErrorfrom Jira Cloud and Jira Server in that case. The task now treats it as a halt, the same waysync_assignee_outbounddoes: no retries (it's a config issue, so retrying won't help) and no synced analytics event. Also removes the 2018TODO(jess).No other
sync_status_outboundimplementation raisesIntegrationConfigurationErrortoday, so the new halt only affects Jira.via richard.
--
View Session [Sentry]