Repository navigation
Conversation
…a scope Add event_attachment:read. A service account has no role, so it needs this scope to download event attachments instead of depending on the org's attachments role. Members are unchanged: they still need the attachments role. Only managers and owners hold the scope, since a scope is grantable to a service account only by someone who holds it. They can already change the attachments role, so they gain nothing.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 46d7618. Configure here.
arslnb
approved these changes
Nov 13, 2026
…:read The endpoint's ProjectPermission needs project:read before the attachment scope is checked, so the service account tests were denied by the base check. Grant project:read so they exercise the event_attachment:read gate, and type the helper's response as HttpResponse so mypy sees .content. Claude-Session: https://claude.ai/code/session_01XgqSAzy2Dt6DYCbvqLnKum
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds an
event_attachment:readscope. A service account needs it to download event attachments; the org's attachments role no longer decides. Members are unchanged: they still need the attachments role.Only managers and owners hold the scope, because you can only grant a service account scopes you hold. Both can already change the attachments role (
org:write), so they gain nothing from it.Before this, a service account could download attachments only when the attachments role was the default. Accounts that need attachments now have to be granted the scope.
Follow-up to Shaun's comment on #130533.