Repository navigation
Attach screenshots to iOS native crashes with runtime initialization - #2941
Merged
Merged
Conversation
bitsandfoxes
marked this pull request as ready for review
November 11, 2026 13:39
bitsandfoxes
requested review from
a team,
jpnurmi,
limbonaut and
tustanivsky
November 11, 2026 13:39
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3358242. Configure here.
jpnurmi
reviewed
Nov 12, 2026
jpnurmi
approved these changes
Nov 12, 2026
bitsandfoxes
commented
Nov 12, 2026
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

With
AttachScreenshoton, iOS native crashes come with a screenshot when the native SDK is initialized at runtime, the default.SentryCocoaBridgeProxy.Initpasses the option to sentry-cocoa, which then takes the screenshot in its crash handler. Build-time initialization already passed it.What sentry-cocoa attaches screenshots to, on both iOS initialization paths:
SetBeforeCaptureScreenshotorSetBeforeSendScreenshotis set. These C# callbacks can't run inside the crash handler, so a game that skips or masks screenshots through them gets no native-crash screenshot instead of an unmasked one.SentryUnityOptions.AttachNativeCrashScreenshotholds that rule for both paths.beforeCaptureScreenshotblock that returnsNO; sentry-cocoa's crash-time screenshot doesn't call it. Screenshots for C# events keep coming from the Unity SDK.With build-time initialization, only callbacks set in the
OptionsConfigurationare seen when the options are generated, as with every other build-time option.Tests:
ShouldAttachScreenshot_*inSentryNativeIosTestscover the platform, the option and both callbacks; the iOS case with the option on fails onmain.NativeOptionsTestscover the generatedattachScreenshotvalue and thebeforeCaptureScreenshotblock.Not verified on a device: whether the crash-time screenshot shows the Metal-rendered game view.
🤖 Generated with Claude Code