Repository navigation
Keep CLI options set in code out of the saved options asset - #2938
Merged
Merged
Conversation
JoshuaMoelans
approved these changes
Nov 11, 2026
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Keep CLI options set in code out of the saved options asset ([#2938](https://github.com/getsentry/sentry-unity/pull/2938))If none of the above apply, you can opt out of this check by adding |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lands the change from #2927 on
main. #2927 was merged into a stale base branch instead ofmain, so its fix isn't onmainyet.LoadCliOptionsruns the user'sSentryCliOptionsConfigurationon theSentryCliOptionsasset itself. That's the same instance the Sentry window edits, and the window saves it when it loses focus. So a value set in code, such as an auth token read fromSENTRY_AUTH_TOKEN, ends up written intoSentryCliOptions.assetand can be committed to the project.LoadCliOptionsnow runs the configuration on a copy made withObject.Instantiate, so the asset keeps only what was entered in the window.Tests:
LoadCliOptions_ConfigurationSetsAuth_DoesNotChangeSavedAssetfails without the fix.LoadCliOptions_OptionsAssetDoesNotExist_ReturnsNullcovers the missing-asset path.🤖 Generated with Claude Code