Repository navigation
test: Save Xbox game config atomically in build hook - #2937
Merged
Merged
Conversation
The Xbox build preprocessor saved `ScarlettGame.config` in place with `XmlDocument.Save`, which holds the file open exclusively while writing. Unity watches the game config and re-reads it on change, so a read that lands mid-write fails with a sharing violation. Unity logs that as an error, and `BuildOptions.StrictMode` turns it into a failed build: ```text Failed to read Game Config file, System.IO.IOException: Sharing violation on path <...> ``` Save to the project's `Temp` folder instead and swap the complete file in with `File.Replace`, so the watcher never sees a partially written file. Failed run: https://github.com/getsentry/sentry-xbox/actions/runs/42793976990/job/129758551877
jpnurmi
marked this pull request as ready for review
November 10, 2026 14:18
bitsandfoxes
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xbox build preprocessor in the integration test project now saves
ScarlettGame.configto the project'sTempfolder and swaps it intoProjectSettingswithFile.Replace, instead of saving it in place.Unity watches the game config and re-reads it on change. Saving in place with
XmlDocument.Savekeeps the file locked while writing, so a re-read that lands mid-write fails with a sharing violation. Unity logs that as an error, andBuildOptions.StrictModefails the build. This made the Xbox integration build flaky (failed run).The watcher should still see the replaced file and reload it. On the first Xbox build, it is worth confirming that the built
MicrosoftGame.configstill containsPersistentLocalStorage.#skip-changelog