Repository navigation
Conversation
| @sentry_monitor_slug ||= begin | ||
| slug = name.gsub("::", "-").downcase | ||
| slug[-MAX_SLUG_LENGTH..-1] || slug | ||
| slug = name.gsub("::", "-").gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').gsub(/([a-z\d])([A-Z])/, '\1_\2').downcase |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
There was a problem hiding this comment.
Updated group ([A-Z]+) from unlimited match to max 1000 characters.
|
Latest mainstream merged |
|
Tracking issue for this change (including slug format selection for transition): #3215 |
solnic
left a comment
There was a problem hiding this comment.
Thanks for helping out with Good Job. Please remove CHANGELOG.md change as we generate changelog entries automatically (and optionally refine them manually) during the release process.
Hi! Thank you too! I will align this PR with issue i created today and get rid of CHANGELOG.md entries. |
779b1da to
62bd057
Compare
62bd057 to
f6e46ea
Compare
Rebase onto current master and align with getsentry#3215. Default class-name slugs stay legacy; `:underscore` adds word breaks and hash truncation via shared `Sentry::Cron::Slug` helpers. No CHANGELOG edit.
f6e46ea to
934e30b
Compare
Name describes the mashed CamelCase shape, not transition status.
|
@solnic PR is ready. |
Summary
Aligns default cron monitor slug derivation with #3215, rebased onto current
master(includesSentry::Cron::Slugfrom #3200).HappyWorkerWithCron→happy_worker_with_cron):underscoreslugs keep a SHA256 prefix of the dropped part plus a readable tail (≤ 50 chars)config.cron.monitor_slug_formatselects:mashed(default) or:underscorefor derived slugs onlysentry_monitor_check_ins(slug: ...)still wins; one format per process (no dual-emit)Sentry::Cron::Slug;Slug.fromfor job keys is unchangedCHANGELOG.mdedit (generated at release)Test plan
sentry-rubycron slug + monitor_check_ins specssentry-sidekiqsidekiq + sidekiq-scheduler specs (Redis)sentry-railsgood_job + good_job_cron + isolated good_job_cron specs (Postgres)fixes #3215
fixes #2594