Skip to content

rails: exclude Good Job concurrency and throttle exceeded errors by default #3216

Open

Description

@amkisko

Summary

When good_job is loaded, append Good Job concurrency and throttle exceeded errors to the SDK's default excluded exceptions, matching Sidekiq's treatment of expected retry-control failures.

Motivation

GoodJob::ActiveJobExtensions::Concurrency::ConcurrencyExceededError and ThrottleExceededError are normal control flow under perform limits / throttles. Reporting them as application errors creates noise.

sentry-sidekiq already ships IGNORE_DEFAULT for Sidekiq::JobRetry::Skip and Handled. Official Good Job ActiveJob + cron support (#3199, #3200) does not yet exclude these Good Job errors.

Specification

  • If GoodJob is defined at configuration time, concat these class names onto excluded_exceptions:
    • GoodJob::ActiveJobExtensions::Concurrency::ConcurrencyExceededError
    • GoodJob::ActiveJobExtensions::Concurrency::ThrottleExceededError
  • No hard gem dependency on good_job in the gemspec.
  • Hosts can remove either string from excluded_exceptions to opt back in.
  • Cron check-ins (feat(jobs): support for good job cron check-ins #3200) stay separate; this issue is only error event exclusion.

Guide-level

With Good Job concurrency limits, rejected runs stop appearing as Sentry issues by default. To keep them:

config.excluded_exceptions.delete(
  "GoodJob::ActiveJobExtensions::Concurrency::ConcurrencyExceededError"
)

Drawbacks / alternatives

  • Adopt: some hosts may want these events; override remains.
  • Do nothing: noise for common Good Job setups.
  • Rejected: require community sentry-good_job for exclusion only.

Prior art

  • Sentry::Sidekiq::IGNORE_DEFAULT
  • Community gem Sentry::GoodJob::IGNORE_DEFAULT (prior art only)

Unresolved questions

  • Append in Sentry::Rails configuration callback, or only when :good_job_cron / Good Job adapter detection runs?

References

Activity

  1. linear-code commented on Nov 18, 2026

    @linear-code
  2. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions