Repository navigation
Conversation
`sentryWebViewProps` is a helper rather than an integration, so it was invisible to Sentry's feature-adoption telemetry. Register a no-op `WebViewTracePropagation` marker when the helper is used, so the feature flows through to `event.sdk.integrations` — the channel used to measure adoption across SDKs (same approach as GlobalErrorBoundary, NavigationContainer, MobileReplay). Idempotent and fails quietly. Follow-up to #6794. Aligns with the WebView adoption markers planned for the Apple, Android, and Flutter SDKs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antonis
force-pushed
the
feat/webview-adoption-marker
branch
from
October 23, 2026 13:20
39a0302 to
8951080
Compare
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
|
antonis
marked this pull request as ready for review
October 23, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Follow-up to #6794.
sentryWebViewPropsis a helper rather than an integration, so it was invisible to Sentry's feature-adoption telemetry (it never appears inevent.sdk.integrations).This registers a no-op
WebViewTracePropagationmarker (via the existingregisterFeatureMarkerutil) whensentryWebViewPropsis called, so the feature flows through toevent.sdk.integrations— the channel Sentry uses to measure feature adoption across SDKs. Same approach already used byGlobalErrorBoundary,NavigationContainer, andMobileReplay.WEBVIEW_INTEGRATION_NAME); no public API change (api-report unchanged).💡 Motivation and Context
Without a marker we can't measure how many apps enable WebView trace propagation. The feature is a plain helper, so it needs an explicit adoption signal.
This is the React Native half of a cross-SDK effort — matching issues are filed for the native SDKs with the aligned marker name
WebViewTracePropagation:💚 How did you test it?
Unit tests in
packages/core/test/tracing/webview.test.ts(4 new): registers on use; registers even with no active trace; idempotent; no-throw when no client. Local: 66/66 tests pass,webview.ts100% covered, build green, api-report unchanged, oxlint/oxfmt/side-effects/circular-dep all pass.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Mirror the adoption marker on the native SDKs (COCOA-2097, JAVA-796, DART-483) with the same
WebViewTracePropagationname.🤖 Generated with Claude Code