Repository navigation
fix(server-utils): Fix orchestrion source maps of instrumented modules - #25772
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: da369a5 (PR test merge using develop at 9c93bbd) Against: 9c93bbd (develop) · base run #64212 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 56 successful. See the run.
Successful checks
|
JPeer264
marked this pull request as ready for review
October 27, 2026 22:11
JPeer264
requested review from
Lms24,
andreiborza,
isaacs and
mydea
and removed request for
a team,
andreiborza and
mydea
October 27, 2026 22:11
isaacs
approved these changes
Oct 27, 2026
Lms24
reviewed
Oct 28, 2026
Lms24
requested review from
msonnb and
nicohrubec
and removed request for
a team
October 29, 2026 15:54
Lms24
approved these changes
Oct 29, 2026
Lms24
force-pushed
the
jp/orchestrion-transform-sourcemap-sources
branch
from
October 29, 2026 16:06
bcb8ac4 to
3c12fcc
Compare
`@apm-js-collab/code-transformer-bundler-plugins` 0.7.4 gave the combined input source map to the code transformer once `outputOptions` had run, and Rolldown calls `outputOptions` before the transforms. The transformer then added a second source `<package>/<file>` (for example `ioredis/built/Redis.js`) without `sourcesContent`. That file does not exist, so source map flattening (for example in `@sentry/sveltekit`) failed for the whole chunk. 0.7.5 gives the real file path to the transformer (code-transformer 0.19.0) and no longer gives it the input map, so the map of an instrumented module only names its file in `node_modules`. This also fixes the source name of instrumented modules in webpack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and tracing-hooks Aligns @apm-js-collab/code-transformer on 0.19.0 so only one version is installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lms24
force-pushed
the
jp/orchestrion-transform-sourcemap-sources
branch
from
October 29, 2026 17:26
3c12fcc to
01cce50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #25329
closes JS-3928
Description
This bumps
@apm-js-collab/code-transformer-bundler-pluginsto 0.7.5, which has the upstream fix (apm-js-collab/code-transformer-bundler-plugins#50, nodejs/orchestrion-js#104). The source map of an instrumented module now names its real file innode_modules, withsourcesContent. Before, Vite 8 and webpack builds had a<package>/<file>source that does not exist (for exampleioredis/built/Redis.js), and source map flattening in@sentry/sveltekitfailed for that chunk.Type decisions
code-transformer 0.19.0 also allows a function in the
transformfield of an instrumentation. I castserializeInstrumentationsto our vendored types, so the publictransformtype staysstring. The alternative is to also allow a function in the vendored type.