Repository navigation
Conversation
`nestIntegration({ monitorCronJobs: true })` sends check-ins for every
`@Cron()` method, with the schedule from `@Cron()` as monitor config.
The slug is the `@Cron()` name, else `ClassName.methodName`.
`excludeCronJobs` skips jobs; methods with `@SentryCron` keep their slug.
Co-Authored-By: Claude <noreply@anthropic.com>
1 of 3 tasks
Contributor
size-limit report 📦Compared: bce952f (PR test merge using danf/nestjs-cron-config at a9a89d7) Against: de10e52 (danf/nestjs-cron-config) · base run #64016
|
wedamija
changed the title
wedamija
marked this pull request as ready for review
October 20, 2026 23:53
wedamija
requested review from
chargome and
s1gr1d
and removed request for
a team
October 20, 2026 23:53
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
@nestjs/schedule runs @Cron methods as cron CronJobs, so with monitorCronJobs and cronJobIntegration both on each run sent two sets of check-ins. Mark the onTick Nest passes to CronJob when the method already sends check-ins.
wedamija
requested review from
andreiborza and
isaacs
and removed request for
a team
October 28, 2026 19:20
…nf/nestjs-cron-auto-monitor # Conflicts: # packages/nestjs/src/integrations/orchestrion-subscriber.ts
wedamija
requested review from
logaretm and
msonnb
and removed request for
a team
October 28, 2026 19:49
Key the monitored check on the @Cron() options metadata, which outer decorators copy, so it doesn't depend on decorator order.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 61 successful. See the run.
Successful checks
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c123c6. Configure here.
…-nest-auto # Conflicts: # packages/nestjs/src/decorators.ts # packages/nestjs/src/integrations/helpers.ts # packages/nestjs/src/integrations/orchestrion-subscriber.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Adds
monitorCronJobstonestIntegration. When it's on, every@Cron()method sends check-ins with the schedule and time zone from@Cron()as the monitor config, so apps don't need@SentryCronon each method. It is off by default. The slug is the@Cron()name, orClassName.methodNamewithout one.Methods that also have
@SentryCronkeep their slug and send one set of check-ins. Schedules Crons can't express, like every 10 seconds, check in without a config. It needsenableRuntimeChannelInjection, which is on by default.Stacked on #25013.