Skip to content

docs: e2e results on main before the next prerelease - #1434

Merged
EtienneLescot merged 2 commits into
mainfrom
pilot/e2e-1422-log
Oct 30, 2026
Merged

EtienneLescot merged 2 commits into
mainfrom
pilot/e2e-1422-log

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Refs #1422

Logs the e2e pass on main before the next prerelease, all four rows in manual-e2e-checklist.md:

  • macOS (local ad-hoc build, 5d82a0cb2): minimal pass, no defect.
  • Linux (CI AppImage, Wayland): minimal pass + 5 diff items, no defect.
  • Windows (CI NSIS x64): pass, no defect.
  • Signed CI DMG (build run 40874803001, 09ed9a231, after ci: install Rust before the macOS compositor build in build.yml #1424): arm64 DMG notarized and stapled, installed and run through launch → HUD → take → editor → MP4 export on a Mac mini M1, no defect. x64 DMG signature and notarization checked, not run.

What each pass did not cover is listed in its row.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added prerelease test records for macOS, Linux, and Windows, including tested builds and environments, observed capture, editing, and export results, and noted coverage gaps.
    • Added a verification record for the signed macOS disk image.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Walkthrough

The manual E2E checklist now records prerelease test results for macOS, Linux, and Windows, plus signed macOS DMG verification. The entries describe tested builds, observed results, and untested areas. No implementation behavior changes.

Changes: Platform test results

Layer / File(s) Summary
Record platform test passes
technical-documentation/testing/manual-e2e-checklist.md
The checklist records macOS, Linux, and Windows prerelease results, plus a signed macOS DMG verification pass. The entries include test coverage, observed results, and remaining gaps.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

  • getopenscreen/openscreen#1422 — This PR records the manual E2E pass tracked by the issue.
  • getopenscreen/openscreen#1431 — This PR records prior main-branch and signed-DMG test results related to the next release-candidate pass.
  • getopenscreen/openscreen#1423 — The checklist records the macOS arm64 DMG build failure and a later signed-DMG validation pass.
  • getopenscreen/openscreen#1340 — The Linux checklist entry tests the behavior addressed by the issue and records a passing result.

Possibly related PRs

Suggested reviewers: my-denia

Merge Risk: Minimal · up to c22b4

This documentation-only change records platform test results and their coverage limits. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the documentation change: recording end-to-end results on main before the next prerelease.
Description check Passed The description provides a clear summary, references issue #1422, and includes detailed testing results for macOS, Linux, Windows, and signed DMG builds. It does not include the template headings or s…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides a clear summary, references issue #1422, and includes detailed testing results for macOS, Linux, Windows, and signed DMG builds. It does not include the template headings or selections for change type, release impact, and desktop impact, but the core information is complete for this documentation-only change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

LanguageTool
technical-documentation/testing/manual-e2e-checklist.md

LanguageTool checks are incomplete because the per-file request limit of 5 was reached. Remaining text was skipped; findings from completed checks are retained.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 23f6109 into main Oct 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant