Repository navigation
feat(client): accept only publishable keys in a web page - #14
Merged
MobileMage merged 1 commit intoNov 8, 2026
Merged
Conversation
Move the spec submodule to 0.4.0 and follow its rules for keys in a browser (SEC-1). In a page with a `document`, the client now accepts only a key that starts with `nipost_pk_`. It reads the key without the white space around it. A secret key keeps its message, and any other key raises a `TypeError` that says it is not a publishable key. Neither message holds the key. A server client still accepts any key. The field reads the kind of a refused key. For an unsupported key it raises `gatepost-error` with the new code `unsupported_key`, shows the same text as for a secret key and logs its own console error. The change also bumps `SPEC_VERSION` in the four packages, adds `unsupported_key` to the messages, the API reports and the READMEs, copies the new glossary entry into `CONTEXT.md` and adds two change files. The new client, key secrecy and field tests failed on the old code, and pass now. `pnpm check` passes in a Linux container. I did not run the Node 22 tests or the Firefox and WebKit journeys. This follows gatepost-dev/spec#16. Claude Code helped write the tests, the code, the docs and the change files, and review the diff. Signed-off-by: Lui Lui <40736418+lui01212@users.noreply.github.com>
Contributor
Author
|
@MobileMage gentle ping on this one when you have time. It's the js side of spec 0.4.0 you mentioned on gatepost-dev/spec#16, and I'm happy to rebase or split it if that's easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the spec submodule to 0.4.0 and follow its rules for keys in a browser (SEC-1).
In a page with a
document, the client now accepts only a key that starts withnipost_pk_. It reads the key without the white space around it. A secret key keeps itsmessage, and any other key raises a
TypeErrorthat says it is not a publishable key.Neither message holds the key. A server client still accepts any key.
The field reads the kind of a refused key. For an unsupported key it raises
gatepost-errorwith the new codeunsupported_key, shows the same text as for a secretkey and logs its own console error. The change also bumps
SPEC_VERSIONin the fourpackages, adds
unsupported_keyto the messages, the API reports and the READMEs, copies thenew glossary entry into
CONTEXT.mdand adds two change files.The new client, key secrecy and field tests failed on the old code, and pass now.
pnpm checkpasses in a Linux container. I did not run the Node 22 tests or the Firefoxand WebKit journeys.
This follows gatepost-dev/spec#16.
Claude Code helped write the tests, the code, the docs and the change files, and review the diff.
Signed-off-by: Lui Lui 40736418+lui01212@users.noreply.github.com