Repository navigation
Read the documented SOLIDERRORS_* email environment variables - #114
Merged
Merged
Conversation
The README documented SOLIDERRORS_SEND_EMAILS, _EMAIL_FROM, _EMAIL_TO and _EMAIL_SUBJECT_PREFIX, but nothing read them. Each email setting now falls back to its variable when not configured; configuration still wins. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README documents
SOLIDERRORS_SEND_EMAILS,SOLIDERRORS_EMAIL_FROM,SOLIDERRORS_EMAIL_TOandSOLIDERRORS_EMAIL_SUBJECT_PREFIX, but nothing read them. Only the username and password variables worked, so anyone who configured email that way got no emails.Each email setting now falls back to its variable when it isn't configured. Explicit configuration still wins, and with neither set the defaults are unchanged (
send_emailsfalse,email_fromsolid_errors@noreply.com).SOLIDERRORS_SEND_EMAILSis read as a boolean, sotrueand1both turn emails on.The variables are read on each call rather than cached, so a value set after boot takes effect. Caching is what had made the
url_optionssetting a no-op until #108.The README example also assigned
ENV["SOLIDERRORS_SEND_EMAILS"] = true, which raisesTypeErrorin Ruby. It now shows the variables in shell form.Tests cover falling back to each variable, configuration winning over the variable, and the defaults. Without the change, the first two fail.
🤖 Generated with Claude Code