Repository navigation
Render the dashboard in apps that don't make English available - #111
Merged
Merged
Conversation
The dashboard forced the :en locale, which raises I18n::InvalidLocale when an app's available_locales leaves English out. It now keeps the app's locale in that case. Fixes #70. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70.
The dashboard wraps every request in
I18n.with_locale(:en), because its strings (including the customdatetime.distance_in_words.shortset) exist only in English. Rails enforces available locales by default, so an app withavailable_locales = [:fr]gotI18n::InvalidLocaleon every dashboard page.The dashboard now switches to English only when the app allows
:en, and otherwise keeps the app's locale. Apps with English see no change. A README note tells apps without English which translations to provide, which is what the reporter did in their workaround.The new request test sets
available_locales = [:fr]and loads the index and error pages. It fails withI18n::InvalidLocalewithout the fix.🤖 Generated with Claude Code