Repository navigation
feat: Enable FoD login via SSO in fcli - #1160
Open
SangameshV wants to merge 1 commit into
Open
SangameshV wants to merge 1 commit into
SangameshV wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fcli fod session login-ssocommand to authenticate through a Chromium-based browser or a supplied SAML assertion. Supports custom FoD API URLs, browser selection/profile options, and named sessions.Assertion file reads are size-bounded, and SSO URLs are normalized to include exactly one saml=1 parameter.
FoD SSO Support in FCLI: Frequently Asked Questions
Why does the SSO flow support Chrome and Edge?
The flow reads the SAML assertion from the completed login page using the Chrome DevTools Protocol (CDP). Chrome and Edge are the browsers explicitly supported by the current implementation.
Which Chromium-based browsers may work?
Chrome, Edge, and Chromium are the strongest candidates because the implementation is built around CDP. Brave, Vivaldi, and Opera may also work when launched using
--browser-path, but they are not explicitly detected or tested, so compatibility should not be promised.Can Firefox or Safari work if the user provides the executable path?
Not with the current implementation. The
--browser-pathoption changes the executable that fcli launches; it does not replace the CDP-based automation. Supporting Firefox or Safari would require a browser-specific automation backend.How does browser discovery work on macOS, Linux, and Windows?
PATHfor Chrome and Edge and includes Chromium during automatic discovery.Users can provide another executable using
--browser-path, but compatibility is not guaranteed.What if no compatible browser is available on the fcli machine?
The user can complete SSO in a browser on another machine and provide the assertion using
--saml-assertion-fileor standard input (stdin).Are there popular alternatives on macOS and Linux?
Safari is a major browser on macOS, and Firefox is a notable alternative on Linux. This makes them relevant candidates for future support, but general browser-share data does not indicate how many fcli users require them. StatCounter's macOS and Linux charts provide directional market-share data only.
What is the recommendation?
Keep the current Chromium-based flow and document its limitations, including the assertion-file workaround. If customer demand justifies broader browser support, add Firefox and Safari through separate automation backends so the existing Chrome and Edge flow remains unchanged.