Skip to content

fix(events): use forward slashes for embed paths - #2011

Merged
flemzord merged 1 commit into
formancehq:mainfrom
Tyagiquamar:fix/events-embed-forward-slash-paths
Oct 28, 2026
Merged

flemzord merged 1 commit into
formancehq:mainfrom
Tyagiquamar:fix/events-embed-forward-slash-paths

Conversation

@Tyagiquamar

Copy link
Copy Markdown
Contributor

Summary

embed.FS requires slash-separated paths, but filepath.Join uses backslashes on
Windows and prevented ComputeSchema from listing service version directories.
@NumaryBot NumaryBot added risk: medium NumaryBot classified this pull request as medium risk. bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. labels Oct 25, 2026

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required automated review completed with no remaining findings.

@flemzord
flemzord merged commit 88d6ee9 into formancehq:main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. risk: medium NumaryBot classified this pull request as medium risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants