Repository navigation
Conversation
- Sort every mark run by combining class instead of keeping the typed order of marks that don't compose (q + dot above + dot below now orders the dot below first) - Use HarfBuzz's modified combining classes, so shadda sorts before Arabic vowels even when the vowel is typed first, and Hebrew, Thai, Telugu and Tibetan marks follow the order fonts expect - Move Arabic modifier combining marks (hamza above or below, small high letters) to the start of their run, as in UTR foliojs#53 - Add tests for Latin reordering, Arabic modifier marks and Allah typed with fatha before shadda in Amiri, matching hb-shape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #403, replacing #404 (rebased on #403, and with a real-font case as asked in #380 (comment)).
q+ U+0307 + U+0323 now orders the dot below first)hb-shape)