Repository navigation
Conversation
lehni
force-pushed
the
fix/woff-getvariation
branch
from
October 18, 2026 16:03
c0f7944 to
7816a1e
Compare
- WOFF previously crashed; WOFF2 silently returned default-instance glyphs - Variations now keep the original source format instead of falling back to plain SFNT - WOFF tables are decompressed up front so internal offsets stay valid for variation processing - WOFF2 transformed glyphs now flow through the variation pipeline - Source state is shared across variations so brotli/inflate doesn't re-run per call, while each variation keeps its own glyph caches
lehni
force-pushed
the
fix/woff-getvariation
branch
from
October 19, 2026 08:09
7816a1e to
356b8fc
Compare
lehni
added a commit
to lineto/fontkit
that referenced
this pull request
Oct 19, 2026
- A variation shared the parent font's cache of glyphs requested with other code points, such as ligatures, and returned the parent's glyphs (foliojs#377) - Reset it along with the glyph cache when cloning the font - Add a test requesting a glyph with other code points from a variation
Contributor
Author
|
Closing in favour of #389, which handles WOFF2 composite glyphs and phantom points correctly and builds each variation as a fresh font. Thanks @sidorares for the thorough comparison. Could you please address the review on #389 and rebase it, so it can be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getVariation()API was broken for compressed source formats: WOFF threw because the variation constructor was always plain SFNT and couldn't reparse the directory, and WOFF2 silently returned default-instance glyphs because the transformed-glyf path bypassed the variation pipeline entirely.Tests cover TTF/WOFF/WOFF2 parity for the upstream variable fixtures (gvar point sharing, HVAR advance variation, HVAR fallback), plus invariants: subclass is preserved, source font isn't mutated, and repeated calls with the same coords are stable.