Repository navigation
Add Hebrew shaper, ported from HarfBuzz - #375
Merged
Merged
Conversation
lehni
force-pushed
the
feature/hebrew-shaper
branch
from
May 20, 2026 20:19
07d759d to
fbc7406
Compare
lehni
force-pushed
the
feature/hebrew-shaper
branch
from
October 18, 2026 16:03
fbc7406 to
5e49b8b
Compare
Member
|
Please resolve the conflicts |
- Compose Hebrew presentation forms (FBxx range) for fonts without GPOS marks, matching `compose_hebrew`; chain compositions step by step (e.g. SHIN + SHIN_DOT + DAGESH → FB2C) instead of bailing after the first match - Reorder patah/qamats + sheva/hiriq + meteg/below mark triplet by codepoint identity, matching `reorder_marks_hebrew`'s end state for both canonical NFC input and HarfBuzz's modified-CCC pre-reorder order - Scope the `hasGposMark` gate to the Hebrew script's GPOS features instead of scanning the global featureList, matching HarfBuzz's per-script `has_gpos_mark` - Add Taamey Frank CLM fixture (GPL v2 + font exception, also used by HB) with 6 shaping tests; reorder tests now exercise real code (each fails with the function disabled)
lehni
force-pushed
the
feature/hebrew-shaper
branch
from
October 18, 2026 16:27
5e49b8b to
2ff8b20
Compare
Contributor
Author
|
@blikblum done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fontkit currently has no dedicated Hebrew shaper — Hebrew (
hebrscript) falls through toDefaultShaper. This PR ports the two Hebrew-specific behaviours from HarfBuzz'shb-ot-shaper-hebrew.cc:!has_gpos_mark(font without GPOS mark positioning), matching HarfBuzz'scompose_hebrew.reorder_marks_hebrew.Tests
Five tests added under
test/shaping.js, ported from HarfBuzz'shebrew-diacritics.tests. Test fixture is Taamey Frank CLM (GPL v2 + font-embedding exception, the same font HB uses in its test suite).Two of the tests specifically exercise the new reorder path and fail without this shaper registered.