Repository navigation
Conversation
- A feature requested by the user was ignored if the shaper had already planned it locally, e.g. frac, which is only applied around U+2044 by default - Such features now apply to the whole run while keeping their stage, matching HarfBuzz's feature merging - Replaces the previous approach of always applying frac globally, which turned all digits into numerators - Add a test for user-enabled frac, matching HarfBuzz output
lehni
force-pushed
the
fix/handle-frac-substitutions-globally
branch
from
October 18, 2026 16:29
35e3be5 to
c5fc8de
Compare
lehni
changed the title
Contributor
Author
|
@blikblum I've updated this one to be identical with the behavior in HarfBuzz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frac, which is only applied around U+2044 by default, so substitution-based fractions (common in monospaced fonts) never worked withfeatures: ['frac']+fracis global there, defaultfrac/numr/dnomstay local)fracglobally, which turned all digits into numeratorsfrac, matchinghb-shape --features=fracoutput