Skip to content

Await notifyForVmServiceConnection when opening a VM service connection #10086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnpryan merged 2 commits into from
Nov 12, 2026
Merged

Await notifyForVmServiceConnection when opening a VM service connection #10086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21cc546
Await notifyForVmServiceConnection when opening a VM service connection
johnpryan Nov 11, 2026
fe3de7e
Add release note for awaiting VM service connection notification
johnpryan Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/devtools_app/lib/src/service/service_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,9 @@ class ServiceConnectionManager {
serviceTrafficLogger = VmServiceTrafficLogger(service!);
}

unawaited(
server.notifyForVmServiceConnection(
vmServiceUri: serviceManager.serviceUri!,
connected: true,
),
await server.notifyForVmServiceConnection(
vmServiceUri: serviceManager.serviceUri!,
connected: true,
);
}

Expand Down
4 changes: 4 additions & 0 deletions packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ TODO: Remove this section if there are not any updates.
or out-of-bounds symbolic links to prevent extensions from accessing arbitrary
files outside the package root or build directory.
[#10083](https://github.com/flutter/devtools/pull/10083)
* Fixed a race condition when running DevTools from the CLI or standalone so
the connected app's package root is registered with the Dart Tooling Daemon
before available DevTools extensions are refreshed.
[#10086](https://github.com/flutter/devtools/pull/10086)

## Advanced developer mode updates

Expand Down
Loading