Repository navigation
Fix serveAvailableExtensions test - #10085
Merged
johnpryan merged 1 commit intoNov 11, 2026
Merged
Conversation
This test wasn't passing the correct X-DevTools-Request header. This fixes it by using the new serveExtensions helper, which includes the header on each request.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors devtools_extensions_api_test.dart by adding an optional packageRootUriOverride parameter to the serveExtensions helper function. This parameter allows overriding the package root URI property in the request query parameters. Additionally, a test case has been simplified to use this helper function instead of manually constructing and handling the request. I have no feedback to provide.
kenzieschmoll
approved these changes
Nov 11, 2026
srawlins
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test wasn't passing the correct X-DevTools-Request header.
This fixes it by using the new serveExtensions helper, which includes the header on each request.