Repository navigation
Detect Dart web apps via dart:js_interop libraries #10045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hkarmoush
wants to merge
4
commits into
flutter:master
Choose a base branch
from
hkarmoush:detect-web-js-interop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ad5969d
Detect Dart web apps via dart:js_interop libraries
hkarmoush 1d918b8
Update release note PR link
hkarmoush d2ae705
Handle offline apps in ConnectedApp.isDartWebApp
hkarmoush aca4b52
Address review: drop redundant js_interop_unsafe check and unused tes…
hkarmoush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
packages/devtools_app_shared/test/service/connected_app_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| // Copyright 2026 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. | ||
|
|
||
| import 'package:devtools_app_shared/service.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| group('ConnectedApp', () { | ||
| test('isDartWebApp is true when dart:html is available', () async { | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: ['dart:html'], | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
| expect(await app.isDartWebApp, isTrue); | ||
| expect(app.isDartWebAppNow, isTrue); | ||
| }); | ||
|
|
||
| test('isDartWebApp is true when dart:js_interop is available', () async { | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: ['dart:js_interop'], | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
| expect(await app.isDartWebApp, isTrue); | ||
| expect(app.isDartWebAppNow, isTrue); | ||
| }); | ||
|
|
||
| test('isDartWebApp is false when no web libraries are available', () async { | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: [ | ||
| 'dart:io', | ||
| 'package:flutter/src/widgets/binding.dart', | ||
| ], | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
| expect(await app.isDartWebApp, isFalse); | ||
| expect(app.isDartWebAppNow, isFalse); | ||
| }); | ||
|
|
||
| test('isDartWebApp short-circuits on first matching library', () async { | ||
| final queriedLibraries = <String>[]; | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: ['dart:html', 'dart:js_interop'], | ||
| onLibraryUriAvailable: queriedLibraries.add, | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
|
|
||
| expect(await app.isDartWebApp, isTrue); | ||
| expect(queriedLibraries, equals(['dart:html'])); | ||
| }); | ||
|
|
||
| test('isDartWebApp caches results', () async { | ||
| var callCount = 0; | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: ['dart:js_interop'], | ||
| onLibraryUriAvailable: (_) => callCount++, | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
|
|
||
| expect(await app.isDartWebApp, isTrue); | ||
| final callsAfterFirst = callCount; | ||
| expect(callsAfterFirst, greaterThan(0)); | ||
|
|
||
| expect(await app.isDartWebApp, isTrue); | ||
| expect(callCount, equals(callsAfterFirst)); | ||
| }); | ||
|
|
||
| test('isDartWebAppNow asserts when not initialized', () { | ||
| final serviceManager = _FakeServiceManager(); | ||
| final app = ConnectedApp(serviceManager); | ||
| expect(() => app.isDartWebAppNow, throwsAssertionError); | ||
| }); | ||
|
|
||
| test( | ||
| 'isFlutterWebAppNow is true and isFlutterNativeAppNow is false for modern Flutter web apps', | ||
| () async { | ||
| final serviceManager = _FakeServiceManager( | ||
| availableLibraries: [flutterLibraryUri, 'dart:js_interop'], | ||
| ); | ||
| final app = ConnectedApp(serviceManager); | ||
| expect(await app.isFlutterApp, isTrue); | ||
| expect(await app.isDartWebApp, isTrue); | ||
| expect(app.isFlutterWebAppNow, isTrue); | ||
| expect(app.isFlutterNativeAppNow, isFalse); | ||
| }, | ||
| ); | ||
| }); | ||
|
|
||
| group('OfflineConnectedApp', () { | ||
| test( | ||
| 'isDartWebApp returns the recorded value without a service manager', | ||
| () async { | ||
| expect( | ||
| await OfflineConnectedApp(isDartWebAppNow: true).isDartWebApp, | ||
| isTrue, | ||
| ); | ||
| expect( | ||
| await OfflineConnectedApp(isDartWebAppNow: false).isDartWebApp, | ||
| isFalse, | ||
| ); | ||
| expect(await OfflineConnectedApp().isDartWebApp, isFalse); | ||
| }, | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| class _FakeServiceManager extends Fake implements ServiceManager { | ||
| _FakeServiceManager({ | ||
| this.availableLibraries = const [], | ||
| this.onLibraryUriAvailable, | ||
| }); | ||
|
|
||
| final List<String> availableLibraries; | ||
| final void Function(String uri)? onLibraryUriAvailable; | ||
|
|
||
| @override | ||
| bool libraryUriAvailableNow(String? uri) { | ||
| if (uri == null) return false; | ||
| onLibraryUriAvailable?.call(uri); | ||
| return availableLibraries.any((u) => u.startsWith(uri)); | ||
| } | ||
|
|
||
| @override | ||
| Future<bool> libraryUriAvailable(String uri) async { | ||
| return libraryUriAvailableNow(uri); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.