Repository navigation
[geolocator] Report altitude accuracy, vertical speed and stream speed/heading/accuracy - #1193
Open
seungsoo47 wants to merge 2 commits into
Open
seungsoo47 wants to merge 2 commits into
seungsoo47 wants to merge 2 commits into
Conversation
Fill the Position fields that were always reported as unavailable on Tizen. - altitude_accuracy: the vertical accuracy (m) from location_manager_get_last_location. - vertical_speed: the climb value converted from km/h to m/s, for both the last known and the current position. Upstream: - Baseflow/flutter-geolocator#1799 (geolocator_platform_interface 4.4.0, vertical_speed) - Baseflow/flutter-geolocator#1793 (geolocator_platform_interface 4.3.0, has* flags for altitude_accuracy)
The position stream used location_manager_set_position_updated_cb, whose callback only carries latitude, longitude, altitude and timestamp. So every streamed Position had hasSpeed, hasHeading and hasAccuracy false. Switch to location_manager_set_location_changed_cb (Tizen 2.4+), which also carries speed (km/h, converted to m/s), direction and horizontal accuracy, with the same interval. Upstream: geolocator_platform_interface Position fields (Baseflow/flutter-geolocator#1793, Baseflow/flutter-geolocator#1799).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 208869b9ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill
Positionfields that Tizen always reported as unavailable.altitudeAccuracy: the vertical accuracy (m) fromlocation_manager_get_last_location, for the last known position.verticalSpeed: the climb value converted from km/h to m/s, for the current and last known positions.speed,heading,accuracyfor the position stream: the stream usedlocation_manager_set_position_updated_cb, whose callback only carries latitude, longitude, altitude and timestamp, sohasSpeed,hasHeadingandhasAccuracywere always false. It now useslocation_manager_set_location_changed_cb(Tizen 2.4+), which also carries speed (km/h, converted to m/s), direction and horizontal accuracy, with the same interval.Also bumps
geolocator_platform_interfaceto^4.4.0(needed forverticalSpeed) and the package version to 1.1.0.Upstream:
has*flags)verticalSpeed)Integration tests are added for the new fields on the current position, the last known position and the position stream.