Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 259c0c2a03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
All stubs shared a single event channel and native event sink, so only the stub that called listen() last received events. close() also destroyed the native handle that the finalizer later destroyed again. Give each stub its own event channel so several stubs can listen at the same time, and make close() release the native handle exactly once. Calling close() again returns the same completion, and any operation on a closed stub throws StateError. listen() now completes after the stub's channel is set up and throws when that setup fails, like ProxyBase.connect(). The lifecycle suite in example/client/integration_test/rpc_lifecycle.dart needs example/server/integration_test/rpc_server.dart running in another terminal, so it is kept out of automatic test discovery.
JSUYA
force-pushed
the
fix/tizen-rpc-port-lifecycle
branch
from
October 20, 2026 09:15
259c0c2 to
5955a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All stubs shared a single event channel and native event sink, so only the stub that called listen() last received events. close() also destroyed the native handle that the finalizer later destroyed again.
Give each stub its own event channel so several stubs can listen at the same time, and make close() release the native handle exactly once. Calling close() again returns the same completion, and any operation on a closed stub throws StateError.