Repository navigation
INTER-2765: ci: drop pull_request_target checks from functional tests - #306
Conversation
The workflow only triggers on pull_request, so the pull_request_target branch never ran. Use a single default checkout. INTER-2765
|
pnpm exec changesetto create a changeset. |
Coverage report
Test suite run success132 tests passing in 30 suites. Report generated by 🧪jest coverage report action from 2686d76 Show full coverage report
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the workflow checkout simplification.
No open issues 🎉
What changed in this PR
Simplifies checkout in the functional test workflow by removing unused pull_request_target handling, preserving checkout behavior for the workflow’s existing triggers.
Changes:
- Removes the conditional checkout of the pull request’s head commit.
- Makes the existing default checkout step unconditional.
| File | Description |
|---|---|
.github/workflows/functional_tests.yml |
Removes obsolete event-specific checkout logic. |
Review effort: Balanced
Context
INTER-2765 | Securely using pull_request_target
Why
functional_tests.ymlhad a leftover checkout step forpull_request_target, a trigger that GitHub will stop supporting on Dec 2, 2026 and that this workflow no longer uses.Things to note
pull_request, so this only removes a step that never ran. Checkout behavior is unchanged.Verification
Proven by this PR's own Functional tests matrix run.