Skip to content

INTER-2765: ci: drop pull_request_target checks from functional tests - #306

Merged
JuroUhlar merged 1 commit into
mainfrom
INTER-2765-ci-remove-pull-request-target
Nov 9, 2026
Merged

JuroUhlar merged 1 commit into
mainfrom
INTER-2765-ci-remove-pull-request-target

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Context

INTER-2765 | Securely using pull_request_target

Why

functional_tests.yml had a leftover checkout step for pull_request_target, a trigger that GitHub will stop supporting on Dec 2, 2026 and that this workflow no longer uses.

Things to note

  • The workflow already triggers on pull_request, so this only removes a step that never ran. Checkout behavior is unchanged.

Verification

Proven by this PR's own Functional tests matrix run.

The workflow only triggers on pull_request, so the pull_request_target
branch never ran. Use a single default checkout.

INTER-2765
@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2686d76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JuroUhlar
JuroUhlar requested a balanced review from Copilot November 5, 2026 14:28
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.25% 168/171
🟢 Branches 97.03% 98/101
🟢 Functions 100% 37/37
🟢 Lines 98.21% 165/168

Test suite run success

132 tests passing in 30 suites.

Report generated by 🧪jest coverage report action from 2686d76

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.24 97.02 100 98.21
🟢  src 98.54 98.76 100 98.51
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 362,366
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the workflow checkout simplification.

No open issues 🎉

What changed in this PR

Simplifies checkout in the functional test workflow by removing unused pull_request_target handling, preserving checkout behavior for the workflow’s existing triggers.

Changes:

  • Removes the conditional checkout of the pull request’s head commit.
  • Makes the existing default checkout step unconditional.
File Description
.github/​workflows/​functional_tests.yml Removes obsolete event-specific checkout logic.

Review effort: Balanced

@JuroUhlar
JuroUhlar marked this pull request as ready for review November 5, 2026 14:36
@JuroUhlar
JuroUhlar merged commit d2fac3e into main Nov 9, 2026
20 checks passed
@JuroUhlar
JuroUhlar deleted the INTER-2765-ci-remove-pull-request-target branch November 9, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants