Repository navigation
feat: request ID response header from BootUI 2.5.0 - #269
Merged
Merged
Conversation
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
The capture-overhead test ran ten alternating base/branch pairs at -n 0. Primary capture overhead values (ms): Base: 0.104, 0.078, 0.093, 0.093, 0.078, 0.077, 0.160, 0.089, 0.090, 0.080 Branch: 0.101, 0.113, 0.114, 0.103, 0.098, 0.162, 0.101, 0.097, 0.104, 0.107 All 20 primary runs passed the 0.200 ms budget. The suspended-path budget also passed in all 20 runs. Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
The request ID header lane changed skills/sharpit/SKILL.md; the plugin ships a byte-identical copy, pinned by tests/test_agent_plugin.py. Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
…ader Signed-off-by: Flavio Oliva <ffroliva@gmail.com>
ffroliva
marked this pull request as ready for review
November 22, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports BootUI 2.5.0's request ID response header (BootUI #1675). Lane A8 of the 0.8.0 plan.
X-Sharpit-Request-Idon HTTP responses, on by default as in BootUI, behind BootUI's gates: theSHARPIT_HTTP_EXCHANGES_EXPOSE_REQUEST_ID_HEADERproperty (opt-out), the HTTP Exchanges panel, and the guard's owntrusted-source decision (
guard.is_trusted_source), so the header never trusts more than the guard does.application-set header always wins, including duplicates, and is never overwritten or added to.
responses are covered.
header will not be emitted.
docs/reference/matrix-updates/0.8.0-a8.tsv(the header name).Tests
tests/fastapi/test_request_id_header.pyrelease/0.8.0tests/fastapi/test_request_id_header.pyrelease/0.8.0tests/fastapi/test_http_probe_api.pyrequest idabsentCapture overhead budget (
tests/fastapi/test_capture_overhead.py, alone,-n 0), ten alternating paired runs, allunder 0.200 ms: base 0.077–0.160 ms, branch 0.097–0.162 ms.
567 tests in the parity, request-ID, probe and import-boundary suites pass; ruff and pyright pass.