Repository navigation
Conversation
dahlia
added
documentation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the primary change: migrating agent-skill management to pnpm 12. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The description directly matches the changeset. It explains the pnpm 12 upgrade, migration from skills-npm and vendored skills, Git dependency pinning and approvals, Relay dependency filtering, Chilli… |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (8 skipped: 8 unsupported.)
Full details: Description check
-
Explanation
The description directly matches the changeset. It explains the pnpm 12 upgrade, migration from skills-npm and vendored skills, Git dependency pinning and approvals, Relay dependency filtering, ChilliCream sourcing, and reported validation.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Select pnpm 12 through mise and update the contributor and source-install prerequisites. The selected stable release is 12.14.0; the existing lockfile works unchanged with a frozen install. The maintainer asked Codex to upgrade pnpm, run the review loop, and commit. Codex updated the configuration and version references while preserving major-only tool selection. Automated validation passed: frozen installation, mise build/check/test, and 587 tests with 11 skipped. Codex Astra reviewed the diff without actionable findings. OpenCode's model listing failed; Claude review could not authenticate because its OAuth session had expired. Neither reviewer contributed changes. Assisted-by: Codex:gpt-6.1-sol
Approve bundled skills and link them into the shared Claude/Codex and Crush directories through pnpm. Remove skills-npm, its prepare hook and unused dependencies, legacy link ignores, and the Vercel skills lock. Keep GitHub-only skill snapshots with documented sources and replace the duplicate Sacho snapshot with the pinned package's official skill. Document the one-time cleanup of legacy links for existing checkouts. The maintainer asked Codex to consolidate skill installation in pnpm, review the changes, and commit. Codex implemented the configuration and cleanup, retained existing vendored instructions, and verified frozen installs in existing and fresh directories, native links, build, check, and test (587 passed, 11 PostgreSQL tests skipped). Codex Astra's review identified collapsed source links; Codex fixed them and a second review found no further defects. OpenCode model discovery failed and Claude's OAuth session expired, so those independent reviews were unavailable. Assisted-by: Codex:gpt-6.1-sol Assisted-by: Codex:gpt-6-astra
Replace the skill-only registry @sacho/sacho package with the GitHub @dahlia/sacho development dependency at tag 0.3.2, matching the binary managed by mise. Pin its resolved commit and tarball integrity in the pnpm lockfile and approve only that source identity for skill linking. Update the source and contributor documentation with the Git workflow. The maintainer asked Codex to manage the repository-distributed skill through pnpm and its lockfile. Codex generated the dependency and approval configuration, removed the manual snapshot, and verified frozen installs in existing and fresh trees, live links, exact upstream bytes, and the full check task. Application code is unchanged; build and application tests were not rerun for this follow-up. Codex Astra independently found no actionable defects. OpenCode model discovery failed and Claude review was unavailable because its OAuth session had expired. Assisted-by: Codex:gpt-6.1-sol
Replace the five copied Formisch, Valibot, GraphQL schema, and Relay skills with three Git development dependencies. Lock their commits and integrity and grant source-specific skill permissions. All fourteen previously copied files match their Git sources and the requested latest upstream skill contents, including references and Sacho, are unchanged. Keep the ChilliCream revision limited to the GraphQL schema skill. Strip Relay's GitHub-root dependency edges through a pnpm manifest hook and deny its build, since the repository is used only for instructions. Update contributor documentation and skill source/update instructions. The maintainer asked Codex to complete Git-based skill management and check for upstream updates. Codex implemented the configuration and hook, removed the copies, and verified fresh and existing frozen installs, ten native skill links per agent directory, unchanged runtime dependency entries, build, check, and tests. Further AI review was skipped at the maintainer's request. Assisted-by: Codex:gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 12 links skills from installed packages and Git dependencies, with Git commits and package integrity recorded in pnpm-lock.yaml. This replaces
skills-npmand vendored copies with one reproducible install step. Git sources receive commit-specific skill approvals..pnpmfile.mjs excludes Relay's development dependencies, and its build is denied, so installing its skills does not install its toolchain. ChilliCream uses a schema-only revision whose skill content matches the latest upstream version, avoiding unrelated skills from the collection.
Validation
Existing and fresh frozen installs, build, and checks passed. Tests: 587 passed, 11 conditional PostgreSQL tests skipped.
AI assistance
Codex implemented the changes, ran validation, reviewed earlier iterations, and drafted this description. The maintainer directed Git-based sourcing and scope.