Skip to content

fix(checkicmp): socket-open failure is an infrastructure error - #712

Merged
fclairamb merged 3 commits into
mainfrom
feat/todos-2026-10-30
Oct 30, 2026
Merged

fclairamb merged 3 commits into
mainfrom
feat/todos-2026-10-30

Conversation

@fclairamb

@fclairamb fclairamb commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • ICMP checks: when a worker cannot open any ICMP socket (ping_group_range / CAP_NET_RAW, e.g. Fly agents), the check now ends as an infrastructure ERROR with an actionable message instead of reporting the target DOWN. The capability reporting, region placement warning, dash0 region picker marker and Fly docs were already in place (spec 2026-10-28-06).

Batch gate: Go build, scoped tests (checkers, regions, handlers/checks, checkworker) and lint on checkicmp pass. Playwright not run (no frontend change).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fclairamb fclairamb added autopilot frozen Batch PR under review: takes only its own fixes, new work goes to the next batch labels Oct 30, 2026
fclairamb and others added 2 commits October 30, 2026 01:10
Remaining item of the icmp-region-capability spec; the capability, probe,
placement warning, picker marker and Fly docs already shipped.

chore: all checks passing for icmp-region-capability

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fclairamb
fclairamb marked this pull request as ready for review October 30, 2026 00:11
@fclairamb fclairamb changed the title feat: todos 2026-10-30 fix(checkicmp): socket-open failure is an infrastructure error Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (2be7787) to head (eedd219).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   89.76%   89.73%   -0.03%     
==========================================
  Files        1296     1296              
  Lines      132195   132198       +3     
==========================================
- Hits       118665   118632      -33     
- Misses      13521    13557      +36     
  Partials        9        9              
Files with missing lines Coverage Δ
server/internal/checkers/checkicmp/checker.go 90.50% <100.00%> (+0.16%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fclairamb
fclairamb merged commit 208ff0a into main Oct 30, 2026
36 checks passed
@fclairamb
fclairamb deleted the feat/todos-2026-10-30 branch October 30, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge autopilot frozen Batch PR under review: takes only its own fixes, new work goes to the next batch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant