Repository navigation
fix(checkicmp): socket-open failure is an infrastructure error - #712
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Remaining item of the icmp-region-capability spec; the capability, probe, placement warning, picker marker and Fly docs already shipped. chore: all checks passing for icmp-region-capability Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
fclairamb
marked this pull request as ready for review
October 30, 2026 00:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 89.76% 89.73% -0.03%
==========================================
Files 1296 1296
Lines 132195 132198 +3
==========================================
- Hits 118665 118632 -33
- Misses 13521 13557 +36
Partials 9 9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ping_group_range/CAP_NET_RAW, e.g. Fly agents), the check now ends as an infrastructure ERROR with an actionable message instead of reporting the target DOWN. The capability reporting, region placement warning, dash0 region picker marker and Fly docs were already in place (spec 2026-10-28-06).Batch gate: Go build, scoped tests (checkers, regions, handlers/checks, checkworker) and lint on checkicmp pass. Playwright not run (no frontend change).